feat(wp): hot and cold self managed #644
Open
+296
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonVutovB
force-pushed
the
WP-1338-WRW-bugs-1-Build-Unsigned-Consolidation-screen
branch
from
500a538 to
2b6bd0f
Compare
mohammadalfaiyazbitgo
requested changes
Nov 4, 2025
| seed: Yup.string(), | ||
| }).required(); | ||
|
|
||
| const validationSchema = getValidationSchema('cold'); |
Contributor
There was a problem hiding this comment.
this looks like a dangling const ?
|
|
||
| const formik = useFormik<EcdsaFormValues>({ | ||
| onSubmit, | ||
| initialValues: { |
Contributor
There was a problem hiding this comment.
add walletType as the form state, and default to cold. That way you won't need an extra state, and you won't need to add a hook, it could be a straight forward function (useWalletTypeLabels)
| seed: Yup.string(), | ||
| }).required(); | ||
|
|
||
| const validationSchema = getValidationSchema('cold'); |
SimonVutovB
force-pushed
the
WP-1338-WRW-bugs-1-Build-Unsigned-Consolidation-screen
branch
from
91e723f to
313a656
Compare
mohammadalfaiyazbitgo
requested changes
Nov 6, 2025
Contributor
mohammadalfaiyazbitgo
left a comment
mohammadalfaiyazbitgo
left a comment
There was a problem hiding this comment.
let's update the Yup schema, unsure if we need the validation changes added.
Comment on lines
13
to
25
| const getValidationSchema = (walletType: WalletType) => Yup.object({ | ||
| walletType: Yup.string().oneOf(['cold', 'hot']).required(), | ||
| userKey: Yup.string().required(), | ||
| backupKey: Yup.string().required(), | ||
| bitgoKey: Yup.string().required(), | ||
| walletPassphrase: Yup.string(), | ||
| walletPassphrase: walletType === 'hot' ? Yup.string().required() : Yup.string(), | ||
| startingScanIndex: Yup.number(), | ||
| endingScanIndex: Yup.number().moreThan( | ||
| Yup.ref('startingScanIndex'), | ||
| 'Ending scan index must be greater than starting scan index' | ||
| ), | ||
| seed: Yup.string(), | ||
| }).required(); |
Contributor
There was a problem hiding this comment.
now that walletType is a form value, I don't think you need to make this dynamic: https://stackoverflow.com/questions/49394391/conditional-validation-in-yup
Comment on lines
49
to
62
| validate: (values) => { | ||
| try { | ||
| getValidationSchema(values.walletType as WalletType).validateSync(values, { abortEarly: false }); | ||
| return {}; | ||
| } catch (error: any) { | ||
| const errors: Record<string, string> = {}; | ||
| error.inner?.forEach((err: any) => { | ||
| if (err.path) { | ||
| errors[err.path] = err.message; | ||
| } | ||
| }); | ||
| return errors; | ||
| } | ||
| }, |
Contributor
There was a problem hiding this comment.
do you need this?
Comment on lines
68
to
82
| validate: (values) => { | ||
| try { | ||
| getValidationSchema(values.walletType as WalletType).validateSync(values, { abortEarly: false }); | ||
| return {}; | ||
| } catch (error: any) { | ||
| const errors: Record<string, string> = {}; | ||
| error.inner?.forEach((err: any) => { | ||
| if (err.path) { | ||
| errors[err.path] = err.message; | ||
| } | ||
| }); | ||
| return errors; | ||
| } | ||
| }, | ||
| }); |
mohammadalfaiyazbitgo
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: WP-1338